• bullseye.js PATCH

    From Delbert@VERT/DELBERTS to All on Wed Aug 15 14:37:00 2007
    Hi ALL,ãI tried to post a regular diff of this, but it was too messed up at 80 char, soãhere's the hand method:ãIN bulleye.js REPLACE THIS:ãif(str.search(/\.htm/)!=-1)ã bbs.exec("?typehtml -color "+str);ãelseã bbs.exec("?typeasc "+str+" BullsEye Bulletin #"+b);ããWITH THIS:ãif(html) { // if the user can do htmlã if(str.search(/\.htm/)!=-1) // and the file is html thenã console.printfile(fname); // just give it to themã else // otherwise convert from CTRL-A to HTMLã bbs.exec("?typeasc "+str+" BullsEye Bulletin #"+b);ã}ãelse { // if the user can't do htmlã if(str.search(/\.htm/)!=-1) // but that's what the file isã bbs.exec("?typehtml -color "+str); // convert itã else // otherwise just give it to themã console.printfile(fname);ã}ããIN typehtml.js ADD THE FOLOWING:ãload("sbbsdefs.js"); // USER_HTMLããI've found that using elinks --dump (on linux) outputs a very nice lookingãformatted ASCII from an HTML file, BTW.ã-j-ãã---ã þ Synchronet þ Delbert's Place BBS | telnet://delberts.audizar.comã
  • From Digital Man@VERT to Delbert on Wed Aug 15 19:05:48 2007
    Re: bullseye.js PATCHã By: Delbert to All on Wed Aug 15 2007 02:37 pmãã > Hi ALL,ã > I tried to post a regular diff of this, but it was too messed up at 80 char,ã > here's the hand method:ã > IN bulleye.js REPLACE THIS:ãã > WITH THIS:ãã... and why? :-)ãã digital man (xbox-live: digitlman)ããSnapple "Real Fact" #91:ãThere are more telephones then people in Washington D.C.ãNorco, CA WX: 91.2øF, 31% humidity, 0 mph SE wind, 0.00 inches rain/24hrsã---ã þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.netã
  • From Delbert@VERT/DELBERTS to Digital Man on Wed Aug 15 22:15:00 2007
    Re: bullseye.js PATCHã By: Digital Man to Delbert on Wed Aug 15 2007 19:05:00ãã > > WITH THIS:ã > ã > ... and why? :-)ããAs it was it converted to HTML no matter what. Very unattractive on the ANSIãTERM. It looks like Deuce is headed toward HTML capability in syncTERM withãUSER_HTML and ?HTML? in answer.c. I got the impression he just wasn't quiteãdone with the checking done in bullseye.js.ããThe patch in typehtml.js fixes the "not defined" for USER_HTML.ããI uploaded both as diff to your sysop uploads.ããPlease keep up the good work.ã-j-ãã---ã þ Synchronet þ Delbert's Place BBS | telnet://delberts.audizar.comã
  • From Digital Man@VERT to Delbert on Wed Aug 15 22:51:27 2007
    Re: bullseye.js PATCHã By: Delbert to Digital Man on Wed Aug 15 2007 10:15 pmãã > Re: bullseye.js PATCHã > By: Digital Man to Delbert on Wed Aug 15 2007 19:05:00ã > ã > > > WITH THIS:ã > >ã > > ... and why? :-)ã > ã > As it was it converted to HTML no matter what. Very unattractive on the ANSIã > TERM.ããI agree, but the reason for that appears to be this line in typeasc.js:ããif(1 || (user.settings & USER_HTML)) {ããRemoving the "1 ||" should fix it.ãã digital man (xbox-live: digitlman)ããSnapple "Real Fact" #178:ãThe first ballpoint pens were sold in 1945 for $12.00 ãNorco, CA WX: 80.4øF, 41% humidity, 0 mph SE wind, 0.00 inches rain/24hrsã---ã þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.netã
  • From Delbert@VERT/DELBERTS to Digital Man on Thu Aug 16 01:50:00 2007
    Re: bullseye.js PATCHã By: Digital Man to Delbert on Wed Aug 15 2007 22:51:00ãã > > As it was it converted to HTML no matter what. Very unattractive on the Aã > > TERM.ã > ã > I agree, but the reason for that appears to be this line in typeasc.js:ã > ã > if(1 || (user.settings & USER_HTML)) {ã > ã > Removing the "1 ||" should fix it.ã > ãI was wondering what he was doing there. ;) Thanks for the fix.ã-j-ãã---ã þ Synchronet þ Delbert's Place BBS | telnet://delberts.audizar.comã
  • From Delbert@VERT/DELBERTS to Digital Man on Thu Aug 16 05:07:00 2007
    Re: bullseye.js PATCHã By: Delbert to Digital Man on Thu Aug 16 2007 01:50:38ãã > > Removing the "1 ||" should fix it.ã > >ã > I was wondering what he was doing there. ;) Thanks for the fix.ã > -j-ãOh, but wait a minute, when you instead now use load() in bullseye.js, doesn'tãthat include typeasc.js in the same scope? I think that corrputs your "i" inãbullseye.js after that, and also fails to actually load subsequent menuãrequests because your "f" is always already declared after the first selection.ããI'm sending you a diff that fixes it, but I'm sure you'll code the actual fixãmore to your liking. ;)ã-j-ãã---ã þ Synchronet þ Delbert's Place BBS | telnet://delberts.audizar.comã
  • From Delbert@VERT/DELBERTS to Digital Man on Thu Aug 16 05:10:00 2007
    Re: bullseye.js PATCHã By: Delbert to Digital Man on Thu Aug 16 2007 05:07:08ãã > I'm sending you a diff that fixes it, but I'm sure you'll code the actual fiã > more to your liking. ;)ã > -j-ãAlso, it probably breaks typehtml.js the same way.ã-j-ãã---ã þ Synchronet þ Delbert's Place BBS | telnet://delberts.audizar.comã
  • From Digital Man@VERT to Delbert on Thu Aug 16 11:44:12 2007
    Re: bullseye.js PATCHã By: Delbert to Digital Man on Thu Aug 16 2007 05:07 amãã > Re: bullseye.js PATCHã > By: Delbert to Digital Man on Thu Aug 16 2007 01:50:38ã > ã > > > Removing the "1 ||" should fix it.ã > > >ã > > I was wondering what he was doing there. ;) Thanks for the fix.ã > > -j-ã > Oh, but wait a minute, when you instead now use load() in bullseye.js, doesnã > that include typeasc.js in the same scope? I think that corrputs your "i" inã > bullseye.js after that, and also fails to actually load subsequent menuã > requests because your "f" is always already declared after the first selectiã > ã > I'm sending you a diff that fixes it, but I'm sure you'll code the actual fiã > more to your liking. ;)ããIt's working here on Vertrauen just fine. Are you actually having a problem?ãã digital man (xbox-live: digitlman)ããSnapple "Real Fact" #158:ãThe first MTV video was "Video Killed the Radio Star," by the Buggles. ãNorco, CA WX: 91.7øF, 40% humidity, 0 mph ESE wind, 0.00 inches rain/24hrsã---ã þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.netã
  • From Digital Man@VERT to Delbert on Thu Aug 16 12:34:44 2007
    Re: bullseye.js PATCHã By: Delbert to Digital Man on Thu Aug 16 2007 05:07 amãã > I'm sending you a diff that fixes it, but I'm sure you'll code the actual fiã > more to your liking. ;)ããNothing personal. :-)ãã digital man (xbox-live: digitlman)ããSnapple "Real Fact" #132:ãA crocodile cannot move its tongue. ãNorco, CA WX: 94.8øF, 38% humidity, 0 mph ESE wind, 0.00 inches rain/24hrsã---ã þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.netã
  • From Delbert@VERT/DELBERTS to Digital Man on Thu Aug 16 16:11:00 2007
    Re: bullseye.js PATCHã By: Digital Man to Delbert on Thu Aug 16 2007 11:44:00ãã > It's working here on Vertrauen just fine. Are you actually having a problem?ãYes, after installing the fix, it looks like it's working at first, butãactually it only displays the first menu you select. IOW, you pick #3, read it,ãgo back to menu and pick #1, and it just shoes you #3 again, until you exitãbullseye, and rerun it.ããWhatever the first choice is gets a file descripter in typeasc.js, andãsubsequent menu choices fail the if test so the new filename doesn't get a newãfd after that.ããThat, and the "i" from bullseye.js gets changed to a 0 in typeasc.js whenãimplictly defined in the while(). Using load() puts both "i"s into the sameãscope because neither is in a function or anything... changing the "i" inãtypeasc.js to a "j" fixes that. You can see this in the log when it shows thatãthe user chose #1, no matter what they really chose. The #1 is "i" after beingãmade a 0 and then going through the while loop in typeasc.js once.ããThe diff I sent you illustrates this, I think.ããRob, the diffs I send are more to illustrate the problem than they are toãrepresent replacement code. That's all I meant when I said you'd probably wantãto code the real fix your own way. ;) (I put the darn smily thing on there;)ããTo duplicate this bug, tail the log, go to bullseye.js, select #4, read it,ãthen return to the menu and select anything but #4. You will get #4 again, adnãthe log will say you looked at #1 both times.ããYou're sure you're not using bullseye.bin? ;)ãã-j-ãã---ã þ Synchronet þ Delbert's Place BBS | telnet://delberts.audizar.comã
  • From Digital Man@VERT to Delbert on Thu Aug 16 16:17:48 2007
    Re: bullseye.js PATCHã By: Delbert to Digital Man on Thu Aug 16 2007 04:11 pmãã > You're sure you're not using bullseye.bin? ;)ããYup, I'm sure. I committed the fix already, which loads()s the type*.js filesãin their own context/scope.ãã digital man (xbox-live: digitlman)ããSnapple "Real Fact" #158:ãThe first MTV video was "Video Killed the Radio Star," by the Buggles. ãNorco, CA WX: 97.5øF, 30% humidity, 0 mph SSW wind, 0.00 inches rain/24hrsã---ã þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.netã