https://gitlab.synchro.net/main/sbbs/-/commit/af7852df11093dc6ed559f64
Modified Files:
src/sbbs3/main.cpp
Log Message:
Ignore remove() return value purposefully in this case.

Does this resolve Coverity warning? I don't rember.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/2b2d8289b92d7f6e6faa1633
Modified Files:
src/sbbs3/main.cpp
Log Message:
More time_t printf fun.

---
￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/1e734d10425f7ca7fb239931
Modified Files:
src/sbbs3/main.cpp
Log Message:
Remove line that was commented-out 14 years ago

Commit d1182efc

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/0a6c1f00de9e4457f598b4f4
Modified Files:
src/sbbs3/main.cpp
Log Message:
Log a warning if failed to write to spy ring buffer

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/4fa2aa66fda6be0ef693f512
Modified Files:
src/sbbs3/main.cpp
Log Message:
Don't log an error if spy socket write return EPIPE (expected)

Also, resove a new gcc warning about signed/unsigned compares.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/a474017fb7c51f91ef9c4095
Modified Files:
src/sbbs3/main.cpp
Log Message:
sbbs_t::incom() should return NOINP immediately if/when socket disconnected

JS console.inkey() and friends use this as the underlying function to get
input from the TCP socket.

This might address issue #725

Hoping Nelgin will let us know.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/4c893720f8e0c57753b08a91
Modified Files:
src/sbbs3/main.cpp
Log Message:
Attempt to fix error nelgin reported with ssh session timeouts

---
￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/e4adbcb541c6f7139e63d2ca
Modified Files:
src/sbbs3/main.cpp
Log Message:
Prevent the input thread from closing channel that has a session,
but does not yet have a session type.

Also, fix what appears to be a fairly blatant memory leak.

---
￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/346849ac253a08374b9bfca0
Modified Files:
src/sbbs3/main.cpp
Log Message:
Unlock ssh_mutex before calling sftps_recv()

This should fix the sftp hangs...
While FreeBSD will return EDEADLOCK when a mutex would deadlock,
Linux will do what I ask and deadlock.

Since we're not checking the return value of pthread_mutex_lock(),
this would go completely unnoticed on FreeBSD, resulting in the
mutex being unlocked early and all sorts of unprotected accesses
would happen, potentially doing crazy things. On Linux it just
deadlocks, and taking a peek at the thread backtraces makes the
problem obvious.

So, point to Linux for making life more correct for people who
do incorrect things (locking without checking the return value).

I'd also like to thank nelgin, for sticking with me on this issue
and being my gdb puppet.

And really, this commit should be shared by all the contributors
who... 𝆺𝅥𝅮𝆺𝅥𝅮𝆹𝅥𝅯𝆹𝅥𝅯

---
￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/c846776318dc4ca28946083c
Modified Files:
src/sbbs3/main.cpp
Log Message:
Break stuff to test things.

---
￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/eddcfe2f9b10d250d16a6c7f
Modified Files:
src/sbbs3/main.cpp
Log Message:
Now unbreak!

---
￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/be8603b11bd6cf12c6f74256
Modified Files:
src/sbbs3/main.cpp
Log Message:
Replace (and auto-upgrade) ctrl/time.dab with time.ini

This will allow us to change scfg_t.event[].last to a time_t value (from time32_t) whenever we abandon Borland C/C++ in the future.

Now it's trival for sysops to view/edit when their timed events 'last run' values. And there's no more endianness concerns. Bad .dab files, bad, go away.

After I wrote this change, I found the original conversion code in v4upgrade.c which is almost exactly the same (except I was going to write to different filename). Finally actually implemented this. Next up: qnet.dab

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/03be991a6f30b98ae9c0320b
Modified Files:
src/sbbs3/main.cpp
Log Message:
Convert (and auto-upgrade) ctrl/qnet.dab to ctrl/time.ini as well

I suppose this should've been part of the previous commit.

Again, this is almost verbatim what v4upgrade.c did (though never actually used).

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/19ab720de38838ae2e4e1154
Modified Files:
src/sbbs3/main.cpp
Log Message:
Resolve recently introduced warnings about const char* to char* conversion

C++ <sigh>

We don't need a .ini section separator anyway.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/00a80d45d884c9ab547fef31
Modified Files:
src/sbbs3/main.cpp
Log Message:
exec/*.bin cmd shell filenames were case sensitive (must've been lowercase)

... while the mods/*.bin command shell filenames could be any-case!

Only impacted non-Windows systems (UNIX file systems are case-sensitive).

Discovered while making this tutorial video: https://youtu.be/HlwQ0uX4S04

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/76b5c7f4399c7774c368c754
Modified Files:
src/sbbs3/main.cpp
Log Message:
Resolve CID 492287 - we don't care about the fexistcase() return value here

We're just using it to "fix" the case, if the file indeed exists.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.782 1.783
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv1099

Modified Files:
main.cpp
Log Message:
Clear the current attribute after the user stirng input in the JS prompt() function (don't leave it high-intensity white on accident).


---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.783 1.784
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv20792

Modified Files:
main.cpp
Log Message:
The "all nodes in use" message specifically said "telnet nodes". Change to "terminal nodes".


---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.789 1.790
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv533

Modified Files:
main.cpp
Log Message:
Address problem reported by wkitty42:
May 21 00:00:15 southeaststar synchronet: evnt BBS Events Executing external: ?logonlist -m
May 21 00:00:15 southeaststar synchronet: evnt BBS Events !JavaScript warning /sbbs/exec/load/nodedefs.js line 167: Disconnected
... by setting the online mode to ON_LOCAL while executing the sys_daily event.


---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.790 1.791
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv13583

Modified Files:
main.cpp
Log Message:
Don't display full path (just the filename) of errored JS file to user.


---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/b105d77749607d5bc8dacc99
Modified Files:
src/sbbs3/main.cpp
Log Message:
Lower log level of the "Perhaps node is already runnnig" log msg from ERR to WARN

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/8bf25ec78bdcf404e0ddab27
Modified Files:
src/sbbs3/main.cpp
Log Message:
Lower the SSH-related log message severities to WARNING for SSH connections

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/9bf4b7bba19d951f3ca48c96
Modified Files:
src/sbbs3/main.cpp
Log Message:
Don't send telnet commands to spy sockets

send_telnet_cmd() now sends telnet commands/replies directly to the client socket. This avoid the entire output_thread() teeing of sent data to spy sockets/buffers (which may not be Telnet at all).

There are some concerns with this change:
- if client_socket isn't writable, will sendsocket() block?
- if output_thread is sending on the same socket, are our 2/3-byte telnet
commands going to have other output data interleaved within? (seems very
unlikely)

---
￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/cbdb2b494c85d24a7b3b887b
Modified Files:
src/sbbs3/main.cpp
Log Message:
Move the "connect" spy message to where the hostname and IP address are known

---
￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/ec6d7e3edf557779be7e54cd
Modified Files:
src/sbbs3/main.cpp
Log Message:
Don't count guest logins as authenticated connections...

When enforcing the MaxConcurrentConnections limit, don't count connections for user's with blank passwords (i.e. Guest) as authenticated.

---
￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/3a19853b763f35a22ece717c
Modified Files:
src/sbbs3/main.cpp
Log Message:
Address 32-bit GCC warning about printf format

'%lu' expects argument of type 'long unsigned int', but argument 5 has type 'off_t

---
￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/bd78d5c5725843afc6659822
Modified Files:
src/sbbs3/main.cpp
Log Message:
Add timestamp of node.log file to crash.log

When a preexisting node.log file is found, a terminal server crash is suspected. Include the timestamp of the node.log in the message appended to the system log (data/logs/*.log) to help identify the likely time of the crash.

---
￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/6d0ec492cd2a5db51e416548
Modified Files:
src/sbbs3/main.cpp
Log Message:
Ooops, forgot to make btox static

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/db690fadea6237739f73825c
Modified Files:
src/sbbs3/main.cpp
Log Message:
Improve btox() so that it doesnt lead to any buffer overruns

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

Re: src/sbbs3/main.cpp
By: Deon George to Git commit to sbbs/master on Sun Nov 22 2020 12:35 am

https://gitlab.synchro.net/sbbs/sbbs/-/commit/6d0ec492cd2a5db51e416548 Modified Files:
src/sbbs3/main.cpp
Log Message:
Ooops, forgot to make btox static

Oops, I forgot to squash this giant merge. <grimmace>
--
digital man

Rush quote #64:
He's cleaning up his systems to keep his nature pure .. New World Man
Norco, CA WX: 75.9�F, 29.0% humidity, 6 mph NNE wind, 0.00 inches rain/24hrs ---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/82d3ae6e61d8876d35444bdf
Modified Files:
src/sbbs3/main.cpp
Log Message:
Load/keep/refresh each node's configuration in memory.

Previously, all nodes shared the same copy of the configuration in memory. This prevented any node from seeing an updated configuration until all nodes were offline or waiting for connection and could be recycled. Now, no recycling of the server is needed for a node to load a new config. A node in-use *still* cannot reload configuration until the user disconnects, but all you have to do is logon to another unused node and you (or that user) will get an updated configuration. Bots or server recycling problems will no longer prevent the sysop or user from getting a current configuration when connecting to any node.

This is one of those instances of giving the sysop what he wants rather than what he asked for. I should've done this a long time ago, but the idea just occurred to me. You're welcome. :-)

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/827063bb1d4343e145a85ffa
Modified Files:
src/sbbs3/main.cpp
Log Message:
Copy event last-run info from global config into node config

Fixes issue introduced in last commit to this file (the each-node-has-its-own-config-in-memory enhancement) that would prevent users from logging in because their time was reduced for an upcoming event that had already run. The change assumes the event thread is running (its the thing that reads the event last-run info from time.dab). Thanks to mlong for the report.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/07bd3442362ada96e99a4294
Modified Files:
src/sbbs3/main.cpp
Log Message:
Fallback to the "first node" configuration

If a node's configuration can't be loaded (e.g. nodeX/node.cnf is missing), fall-back and load the "first node" (e.g. Node1) configuration. On recent *nix installs (since the migration to Git), the node2+/node.cnf files were not copied/created, so let's solve that soon-to-be-FAQ now.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/656bdb8fe79786b94f7dc5ac
Modified Files:
src/sbbs3/main.cpp
Log Message:
Log a warning when falling-back the loaded node configuration.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

Re: src/sbbs3/main.cpp
By: Rob Swindell to Git commit to main/sbbs/master on Sun Nov 29 2020 12:31 am

another unused node and you (or that user) will get an updated configuration. Bots or server recycling
problems will no longer prevent the sysop or user from getting a current configuration when connecting
to any node.

This is one of those instances of giving the sysop what he wants rather than what he asked for. I
should've done this a long time ago, but the idea just occurred to me. You're welcome. :-)

This is freaking awesome. Thanks DM!

|01bobbobbobbob|09bob|03bob|11bob|03bob|09bob|01bobbobbob |01robrobrobrob|09rob|03rob|11rob|03rob|09rob|01robrobrob
|07

---
� Synchronet � Halls of Valhalla =San=Francisco= Happy Holidays

https://gitlab.synchro.net/main/sbbs/-/commit/d9ea54258ab2a39b3e71bdcf
Modified Files:
src/sbbs3/main.cpp
Log Message:
Don't create a JS "client" object for timed events

There is no actual TCP-client when a timed event is executing, so don't create one in the JS context when the socket is invalid.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/0d8ea19e309c6afd80a587c8
Modified Files:
src/sbbs3/main.cpp
Log Message:
Create node#/client.ini for each node client connection

Paves the way for utilities like umonitor to show client details for node connections (e.g. IP address, hostname, connection duration, etc.)

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/5e46cb0f6cc44b2176c97b0f
Modified Files:
src/sbbs3/main.cpp
Log Message:
Additional/optional 'mode' argument to global prompt() method

Defaults to K_EDIT.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/6713d10cb1f9e44d1cb8a9e6
Modified Files:
src/sbbs3/main.cpp
Log Message:
Fix incorrect 'socket' value for new (highwater) log message

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/06f6b07ddbc0ba9f7d66f5c5
Modified Files:
src/sbbs3/main.cpp
Log Message:
Eliminate large-scoped 'i' variable in bbs_thread()

This is just a code quality (readability) improvement. No functional change.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/59e30dda6bb683b9c1a97298
Modified Files:
src/sbbs3/main.cpp
Log Message:
Fix *nix build

We removed the large-scope 'i', but didn't update the Unix-only blocks of code (dealing with UNIX domain spy sockets).

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/bca9510b25f790f84f59545a
Modified Files:
src/sbbs3/main.cpp
Log Message:
Include current node number intead of socket descriptor in highwater log msg

looks better, more consistent with the log messages before/after it.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/c03ed4b9ce042d5651575e18
Modified Files:
src/sbbs3/main.cpp
Log Message:
Log a warning if any socket inactivity max durations are shorter/equal to ...

to the getkey inactivity timeout.

By setting a socket timeout shorter or equal to the getkey timeout, the getkey timeout effectively does nothing.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/2ce9ccfe50ab05c3bacf2e8d
Modified Files:
src/sbbs3/main.cpp
Log Message:
Reset sbbs_t menu path vars (menu_dir and menu_file) before execing cmd shell

I obvserved an issue with Amessyroom's bbs where his custom (JS) shell is setting bbs.menu_dir but when switching to another stock shell, his menu
files were still being displayed (with mismatching command keys as a result).

bbs.menu_dir (and implicitly, the set_menu_dir Baja function) apparently have not been used in this way (much) before.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/ccab84c359406ffea9695db3
Modified Files:
src/sbbs3/main.cpp
Log Message:
Use new FILE_RETRY_ERRNO() macro for sopen() retries in sbbs_t::nopen()

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/27e30f1277531509630d3ca8
Modified Files:
src/sbbs3/main.cpp
Log Message:
Better support for multiple hosts handling QWK events

First, fix the logged username bug in the "Lock exists" log message.
Next, double check that the trigger file (sem file or REP file) still exists after acquiring the file mutex.

Use a temp varible (fname) to make the code easier to read.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/5956805f6e2e985824a86d52
Modified Files:
src/sbbs3/main.cpp
Log Message:
Log event command-lines (repeating event code was redundant)

Only log messages about QWK mutex files existing when > 60 seconds old

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/3127e4f4b89c73263cadd901
Modified Files:
src/sbbs3/main.cpp
Log Message:
Detect hung event_thread and log details

Add log message when spawning background timed event

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/6df88451e8d9ce67c27bd4d0
Modified Files:
src/sbbs3/main.cpp
Log Message:
Use timestr() instead of ctime_r() for logging full date/times

Also when detecting a blocked event_thread, log the event_code that is/was running last.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/87b22bda88174a8e03e25558
Modified Files:
src/sbbs3/main.cpp
Log Message:
Reolve !ERROR 2 (No such file or directory) removing "data/pack####.now"

glob() results might be out of date by the time we look at each file, just
skip missing QWK pack semaphore files silently. This should resolve the
".now already gone" messages too. Hopefully.

Removed some extraneous quotes around logged event command-lines.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f37e9789f42d73d4991d2ff3
Modified Files:
src/sbbs3/main.cpp
Log Message:
Use fmutex_open() instead of fmutex() to better protect the pack*.lock files

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/6dda18740c154c5f099070d1
Modified Files:
src/sbbs3/main.cpp
Log Message:
Use fmutex_close() and don't log ENOENT errors when removing pack*.now files

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/208f263b94e85ef91dc62cc3
Modified Files:
src/sbbs3/main.cpp
Log Message:
Just a little wording update on the fmutex file open log message

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/2fa8db2b6a1a5da43db71887
Modified Files:
src/sbbs3/main.cpp
Log Message:
Perform "first level Ctrl-C input checking" even when in Telnet BINARY_TX

This condition caused aborting BBS operations via Ctrl-C to fail when connecting from a traditional Telnet client using binary transmission
mode (e.g. telnet -8) or SyncTERM v1.2rc6.

The check of rio_abortable was probably enough to disable this function
during file transfers (e.g. we've had no issues with SSH file transfers
that might include byte 0x03 received from the client), but I added the
check for SS_FILEXFER system status check too, perhaps unnecessary.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/6d7f85680177ba6fef1946f2
Modified Files:
src/sbbs3/main.cpp
Log Message:
Don't use uninitialized variable: lockfname

Where's the compiler warnings guys?

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/fa5321fe8850f6d2d9558312
Modified Files:
src/sbbs3/main.cpp
Log Message:
request_telnet_opt() will ignore all cmds but DO, DONT, WILL and WONT

This allows us to save unitialized telnet_*_option values (i.e. 0x00) and pass those values back to request_telnet_opt() with no side effect.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/277855436d2143b88bd9a501
Modified Files:
src/sbbs3/main.cpp
Log Message:
Fix crash when NO_EVENTS option is set for terminal server

Don't deref that null pointer

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/26886a8c7ba879f2e84d2650
Modified Files:
src/sbbs3/main.cpp
Log Message:
Remove ssh_errors variable.

We're carefully counting the errors, but never looking at the count.

---
￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/89a884e9dca8116090df2d87
Modified Files:
src/sbbs3/main.cpp
Log Message:
Log the error description upon failure to send on socket

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f83b805f2ebdc68d7612ab6d
Modified Files:
src/sbbs3/main.cpp
Log Message:
Don't try to renaming a bad (unpackable) REP packet if it doesn't exist

There still appears to be some race condition with network (Samba) FS
directory caching and opening/locking of files, so it does seem illogical that the packet file wouldn't exist at this point (since we have the lock file opened) but this does still happen on occasion on Vertrauen.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/65ff68a0bb3386cd6d4c3fab
Modified Files:
src/sbbs3/main.cpp
Log Message:
Always unlock nodefile_mutex before calling errormsg()

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/74724d0b83150c1da1a88d74
Modified Files:
src/sbbs3/main.cpp
Log Message:
When searching for unused nodes, skip nodes that have sockets in-use

We already know such nodes are in-use, so no need to read their node.dab
record and put extra contention on the node.dab file. Hoepfully this
reduces or eliminates occurrences of the error:
Node n status is WFC, but the node socket (s) and thread are still in use! Though I kind of expect occurrences of "NODE STATUS FIXUP" errors to likely return.

We could in theory just track status of nodes in memory (for those
nodes that this instance of sbbs controls), and not read the node.dab file at all when checking those nodes' status, but:
- that would prevent out of process control of node status
e.g. using the node utility to mark a node as offline
- we'd have to protect instance of in-memory node status checking/changing
with a mutex

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/a4f032b82ed2ddfbd23e963d
Modified Files:
src/sbbs3/main.cpp
Log Message:
Fix-up node status when node status is in-use, but no socket active

This is a situation we can auto-correct and log a message when we do.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net