https://gitlab.synchro.net/main/sbbs/-/commit/3bf7380f569eababc753e3fc
Modified Files:
src/sbbs3/userdat.c
Log Message:
nodestatus() print internal code rather than xtrn number, if possible

(as a fall back to the full external program name).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/d6293e05bccdff9ff8fbb1c8
Modified Files:
src/sbbs3/userdat.c
Log Message:
Fix logic to add the "partially" prefix to download notification messages

The file_t struct may not have the size of the file pre-poulated, so we needed to call getfilesize() here.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/e7642321545ef80fb73fe183
Modified Files:
src/sbbs3/userdat.c
Log Message:
Fix getnodedat() error handling and usage

If a file descriptor is passed to getnodedat() and the lock retry counter was reached, the file would be closed, but the passed file descriptor reference would not be set to -1. This could result in exceptions (from subsequent read attempts on the referenced file descriptor) in cases where the node.dab could not be locked or read by getnodedat() and was thus closed.

The set/get_node_* helper functions (used by MQTT) were not initializing the node.dab file descriptor (i.e. to -1), so it's possible getnodedat() could
try to read from and close an invalid/wrong open file descriptor. If the local variable happened to be initialized to a value <= 0, then, no problem, but
this is undefined behavior (UB).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 userdat.c 1.224 1.225
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv22402

Modified Files:
userdat.c
Log Message:
Include the protocol and the IP address (if hostname is "<no name>") in the download notification short-mesage (telegram) sent to an uploader from user_downloaded_file().


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 userdat.c 1.225 1.226
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
userdat.c
Log Message:
Resolve gcc warning: braces around scalar initializer



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 userdat.c 1.226 1.227
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv14335

Modified Files:
userdat.c
Log Message:
Added over/underflow protection of 16-bit user fields (e.g. timeon, posts, etc) in adjustuserrec() - as reported by Nelgin, the finder and reporter of bugs. 32-bit fields were protected, but not 16-bit fields, so they could/would
"wrap around" (e.g. after exceed 65535).
I did not add protection for 8-bit integer wrap as there's only one (leech) and that's not relevant/used these days.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 userdat.c 1.227 1.228
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv18787

Modified Files:
userdat.c
Log Message:
Check if client->host is not-blank, not non-NULL.
Resolve warning: comparison of array 'client->host' not equal to a null pointer is always true in Clang


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 userdat.c 1.229 1.230
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv27150

Modified Files:
userdat.c
Log Message:
Recognize the "quiet" directory setting (no download notifications) for
the JS User.downloaded_file() method (used by ecWeb's file download stuff). Thanks Coz.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/1e9d5c2cc05ee318ab629bce
Modified Files:
src/sbbs3/userdat.c
Log Message:
Treat every login failure with no password available as unique

When loginFailure() is called with NULL for the password argument, that indicates there was no password available (e.g. an aborted login attempt) - treat each of these as a unique (not duplicate) failed-login attempt. This'll trigger ban/filter thresholds sooner for clients that hammer servers and disconnect mid-login.

---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/5168429f4fae5bfda1fa9976
Modified Files:
src/sbbs3/userdat.c
Log Message:
My first opportunity to use IS_ALPHANUMERIC ()instead of isalnum()

and I blew it. Here's to learning new tricks.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/0f76860d6b42af92589f6fa2
Modified Files:
src/sbbs3/userdat.c
Log Message:
Include the [F] (forced chat) flag for help in debugging forced-chat.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/3eaf57fe30820f5b0f232328
Modified Files:
src/sbbs3/userdat.c
Log Message:
C version of chk_ar() now supports the DOS keyword...

The "DOS" ARS keyword was always evaluating to false, on all platforms, for the C version of chk_ar(), which is used for populating JS *_area objects and for the User.compare_ars() implementation.

Unfortunately, the startup (sbbs.ini) "NO_DOS" option is not recognized here (yet), so it'll report true (e.g. for Win64 or Linux systems with DOSemu) even if/when the NO_DOS option is set.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/69fc70ab9e59914f5bfceb9f
Modified Files:
src/sbbs3/userdat.c
Log Message:
Extend (and back-off) the user.tab record lock attempts

I'v been getting errors locking user.tab (for read) for a while (over samba), so hopefully this helps. The lockuserdat() total timeout duration extends from about 5 seconds to about 45 seconds (with an incremental back-off).

Implement the same lock-retry logic/limit in putuserdat().

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/3de5f432ff45b91c838f28c8
Modified Files:
src/sbbs3/userdat.c
Log Message:
Delete data/file/*.out directory for new user (if exists)

emailfiles.js puts files here that the user requested to download "via email" and might not have been successfully delivered and deleted. So clean-up.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/d7ed70e42df440ef47895b65
Modified Files:
src/sbbs3/userdat.c
Log Message:
user_downloaded_file() now return false upon statistics update failure

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/0a1265a00a2f193d1d977577
Modified Files:
src/sbbs3/userdat.c
Log Message:
strListFastDelete() now takes a count argument

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/c0c3c3ae007cc6f90469d3e0
Modified Files:
src/sbbs3/userdat.c
Log Message:
Check return value of seekuserdat() in putuserdat() and return failure

... trying to get to bottom of user.tab corruption reported in issue #797.

Also, don't need to seek in lockuserdat() since we always call seekuserdat() first.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/5adf169677b1dee1819f18ca
Modified Files:
src/sbbs3/userdat.c
Log Message:
putuserdat() no longer calls dirtyuserdat() if the write/update failed

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/690bb56e025804cf73cfebbf
Modified Files:
src/sbbs3/userdat.c
Log Message:
A file descriptor of 0 is technically valid (though normally, STDIN)

Likely fix for CID 514647

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/6b5a54d3bf6def6cf0694cd5
Modified Files:
src/sbbs3/userdat.c
Log Message:
Add description comment for find_login_id()

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/df32524348f6987de16ee0d3
Modified Files:
src/sbbs3/userdat.c
Log Message:
Add random jitter to lockuserdat() and putnodedat() retry delays

so that if multiple entities call these functions at the same time, they
don't retry at exactly the same times.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/ccef9d28aad4782f7879354f
Modified Files:
src/sbbs3/userdat.c
Log Message:
Check return value of writeuserfields() in putuserstr()

Return correct error value upon seek failure.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/8fd3f62078dd7035cfb2b4c1
Modified Files:
src/sbbs3/userdat.c
Log Message:
Make user_downloaded_file() tolerant of being passed a file path

... instead of just the file name, as was expected.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/2cb39d9a8dc73a02a03df214
Modified Files:
src/sbbs3/userdat.c
Log Message:
Insure ctrl chars/codes are stripped from nodestatus() output

Use strlcpy instead of strncpy

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/4610fc7b454e891fb09f2663
Modified Files:
src/sbbs3/userdat.c
Log Message:
Fix incorrect use of sizeof in node_vstatus and node_activity

This would cause the "Logout" status and multinode chat activity
strings to be truncated to 3 or 7 chars.

CID 515713 and 515715

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/1743d8afe6f8bd73bed45a9b
Modified Files:
src/sbbs3/userdat.c
Log Message:
Remove the config check from openuserdat()

... since all (almost all) callerd do a config check first.

Also, some callers of openuserdat() were expecting -1 on failure (always).

Functions that returned the return value of openuserdat() upon failure, now return USER_OPEN_ERROR instead, to be consistent.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/d0e0e8c902f604f70108cf21
Modified Files:
src/sbbs3/userdat.c
Log Message:
Go back to using non-blocking periodic/polling user.tab lock attempts

This partially reverts commit 03b84df85.

I observed deadlocks on Linux attempting locks of user.tab on Samba share, which also deadlocked my Windows nodes. Interestingly, the Windows nodes
never deadlocked on their own (after a week of testing) when using blocking locks.

Double the frequency of lock retries - this has helped reduce the observed user.tab lock failures on Vertrauen.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/913567c02f20e31ef659c768
Modified Files:
src/sbbs3/userdat.c
Log Message:
Report a different status for NODE_QUIT than NODE_INUSE

Could be helpful for debugging node status issues at some point

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net