https://gitlab.synchro.net/main/sbbs/-/commit/b1e8d3070d100a5a0ec090aa
Modified Files:
src/sbbs3/js_internal.c
Log Message:
Update docs for js.auto_terminate to clarify: disconnection will trigger too

User disconnection will trigger auto-terminate (eventually) as well. But only in the terminal server.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 js_internal.c 1.95 1.96
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv12239

Modified Files:
js_internal.c
Log Message:
Fix version number in js.exec() documentation: This method was added in v3.17c not v3.16.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 js_internal.c 1.96 1.97
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv18457

Modified Files:
js_internal.c
Log Message:
Fix double-free (of startup_dir) in js.exec() method.
Improve "script missing" error reporting in js.exec().



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 js_internal.c 1.97 1.98
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv26628

Modified Files:
js_internal.c
Log Message:
js.exec() enhancement: if any of the arguments to be passed to the executed script are arrays, pass each element of the array as a separate argument to the child script. This allows one script to generate a variable-length list of arguments to be passed to another.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Just curious... what would it take to get Synchronet up to the current spidermonkey engine?

Related to your recent arguments change for `js.exec()`, having a spread operator would help for when writing such scripts.

js.exec(...params)

--
Michael J. Ryan
tracker1 +o Roughneck BBS

---
þ Synchronet þ Roughneck BBS - coming back 2/2/20

Re: Re: src/sbbs3/js_internal.c
By: Tracker1 to rswindell on Sun Mar 29 2020 01:47 am

Just curious... what would it take to get Synchronet up to the current spidermonkey engine?

A lot of work.

Related to your recent arguments change for `js.exec()`, having a spread operator would help for when writing such scripts.

js.exec(...params)

We don't have the spread operator currently, but reading about it brought me to function.apply() which looks like that can be used to solve the js.exec() problem I had. I don't need to array argument trick. Thanks for the tip!

digital man

This Is Spinal Tap quote #16:
David St. Hubbins: I believe virtually everything I read...
Norco, CA WX: 63.9øF, 54.0% humidity, 3 mph ENE wind, 0.00 inches rain/24hrs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 js_internal.c 1.98 1.99
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv29776

Modified Files:
js_internal.c
Log Message:
Revert the last commit (mostly): don't treat array arguments to js.exec() specially, just pass them on to the script as-is. Included a JSDOC note about the use of js.exec.apply() to pass a variable number of arguments (ala execv).

Thanks Tracker1 for the pointer to 'spread' which led me to function.apply() and the JS-standard method of achieving the result I needed with this enhancement.

I still think that a script that calls exit() is unlikely to expect non-string arguments in the first place, but if we don't need special case behavior, it's better not to add it and keep the behavior consistent with load() and require(). That was the decision of the executive board anyway. :-|



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/41429b5f199747ddbb2ddb8b
Modified Files:
src/sbbs3/js_internal.c
Log Message:
Fix 'js' opbject property descriptions in jsobjs.html.

---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/be9d78c653db953092c336e6
Modified Files:
src/sbbs3/js_internal.c
Log Message:
Eliminate crash in js.on_exit()

Have js.on_exit() throw an exciption with a useful(?) error when the
scope already has private data, and that data is not an on_exit list.

This fixes #182.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/34801e27613644ad3ddd6ca4
Modified Files:
src/sbbs3/js_internal.c
Log Message:
Fix previous commit.

Copy/paste without the update required a single character to have
seven different values... which is unlikely to actually happen.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/876766e10ef7b9f94c22ad18
Modified Files:
src/sbbs3/js_internal.c
Log Message:
May as well check the signature in the OnExit handler too.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/c8a83171c6837d7dabfe698c
Modified Files:
src/sbbs3/js_internal.c
Log Message:
Fix CID 508259: Control flow issue (DEADCODE)

... introduced in commit 54523145

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net