https://gitlab.synchro.net/main/sbbs/-/commit/fb957d1d8844368b19fb5b16
Modified Files:
src/sbbs3/js_file.c
Log Message:
Increase size of file mode string so it's not 4 bytes.

4-bytes is how bit a 32-bit pointer is.

---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/7dcfa20fe2f1ce9eb52a3ba1
Modified Files:
src/sbbs3/js_file.c
Log Message:
Don't convert/store small integers to doubles when reading/writing .ini files

Fix issue #760

UINT_TO_JSVAL automatically handles the storage as the necsesary underlying type in the JS engine.

Values > 0x7fffffff (2147483647) will still be stored (and re-written) as doubles and could be problematic.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 js_file.c 1.190 1.191
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv9740

Modified Files:
js_file.c
Log Message:
Don't try to convert null or undefined arguments to integers.
Moved some dbprintf() lines around a bit.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 js_file.c 1.191 1.192
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv15683

Modified Files:
js_file.c
Log Message:
Special handling of negative numbers in the writeBin() method implementation. JS numbers are double-precision floating points (doubles) and doubles cannot
be converted to unsigned integers uniformly across all architectures (e.g. specifically on ARM, negative numbers would mostly get converted to 0U).

For details, see https://www.embeddeduse.com/2013/08/25/casting-a-negative-float-to-an-unsigned-int/


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 js_file.c 1.192 1.193
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv18066

Modified Files:
js_file.c
Log Message:
Added optional "lowercase" argument to File.iniGetObject() and iniGetAllObjects() to sort of "normalize" the key names into easily-useable (and consistent) JavaScript property names.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 js_file.c 1.193 1.194
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv428

Modified Files:
js_file.c
Log Message:
Restore the previous behavior of File.iniGetObject(null), even though not documented (it says if the section is *undefined*, the root section is read)


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 js_file.c 1.194 1.195
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv4839

Modified Files:
js_file.c
Log Message:
Document the iniGetObject(null) behavior.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 js_file.c 1.195 1.196
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv894

Modified Files:
js_file.c
Log Message:
Update to File.iniGetAllObjects(): read the .ini file all in one go using iniReadFile():
- enables the use of the !include directive in the read .in file
- reduces rewinds/re-reads of the .ini file, speeding up the total operation

I also removed the old crash dump comments from here.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/1af02470226933aa5f04a0f7
Modified Files:
src/sbbs3/js_file.c
Log Message:
JS File.iniGetObject() and .iniGetAllObjects() now support blank strings

If an .ini file is read by either the iniGetObject() or iniGetAllObjects() methods and contains a key with a blank value, that property would be created with an "undefined" value.

Both the iniGetObject() and iniGetAllObjects() methods now accept an additional Boolean argument (which defaults to false), to specify that "blanks" are acceptable. When the "blanks" argument is true, then keys with empty values in the .ini file are created as properties with empty string values (length of 0).

This is going to be useful for modopts.js to read potentially-blank strings from modopts.ini and differentiate between a blank string key and a missing key.

---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/105627890fa49ca6a6198408
Modified Files:
src/sbbs3/js_file.c
Log Message:
Eliminte weird gcc (12.2) warning in release build (only)

Increasing size of mode[] element by 2 bytes eliminated these GCC warnings
that seem like false-positives to me:

sbbs.h:194:48: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
194 | (ret)[JSSTSpos]=(char)JSSTSstrval[JSSTSpos]; \
| ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
js_file.c:225:25: note: in expansion of macro ‘JSSTRING_TO_STRBUF’
225 | JSSTRING_TO_STRBUF(cx, str, p->mode, sizeof(p->mode), NULL);
| ^~~~~~~~~~~~~~~~~~
js_file.c:42:17: note: at offset 5 into destination object ‘mode’ of size 5
42 | char mode[5];
| ^~~~

Similar use of JSSTRING_TO_STRBUF in other files (js_console.cpp, js_archive.c) (with larger target buffers) does not trigger the same warnings.

---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/6ba59a06b546c1ed0e3b2b8b
Modified Files:
src/sbbs3/js_file.c
Log Message:
Add missing NULL pointer check to js_iniReadAll()

iniReadFile() can return NULL upon file read error or malloc error. Let's not crash if that happens.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/5e1087e457db2b41dab45deb
Modified Files:
src/sbbs3/js_file.c
Log Message:
File.read() encodes base64, it doesn't decode.

---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net