• src/sbbs3/js_console.cpp

    From rswindell@VERT to CVS commit on Mon Apr 6 13:10:12 2020
    src/sbbs3 js_console.cpp 1.144 1.145
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv30015

    Modified Files:
    js_console.cpp
    Log Message:
    Fix bug introduced in rev 1.142 with the additional/optional arguments to the yesno() and noyes() methods:
    We need to check the argument count before using the second (optional)
    argument or else it has some garbage/left-over value from some previous JS function call. And no, just increasing the argument count in the method table isn't enough. :-(
    Reported by echicken and DaiTengu, thanks!


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Thu May 7 22:23:38 2020
    src/sbbs3 js_console.cpp 1.147 1.148
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/home/rswindell/sbbs/src/sbbs3

    Modified Files:
    js_console.cpp
    Log Message:
    Resolve GCC warning: unused variable 'argv'



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sat May 9 16:56:13 2020
    src/sbbs3 js_console.cpp 1.150 1.151
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv30941

    Modified Files:
    js_console.cpp
    Log Message:
    Fix the missing "hungry" argument thing caught by GCC.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tue May 12 12:06:07 2020
    src/sbbs3 js_console.cpp 1.151 1.152
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv16716

    Modified Files:
    js_console.cpp
    Log Message:
    As part of the rev 1.147 (add mouse hot sport support) commit, I made what I thought was a harmless change to the JS console.clear() implementation, I changed the call to sbbs->CLS to sbbs->clearscreen(). The sbbs->CLS macro calls outchar(FF) which check the line-counter and does the auto-pause before screen-clear. A direct call to sbbs->clearscreen() does not.
    Just in case someone actually wants the new (but unexpected behavior), I added an optional boolean parameter to console.clear(), autopause (default to true). Pass false if you want to defeat the autopause functionality. This should be effectively the same as setting the console.line_counter = 0 before calling console.clear(), but it also totally bypasses sbbs_t::outchar,
    so there could be other differences I'm not thinking of.
    Anyway, this fixes the lack of auto-screen pauses in JS mods recently introduced.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sun May 24 01:16:52 2020
    src/sbbs3 js_console.cpp 1.153 1.154
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv23820

    Modified Files:
    js_console.cpp
    Log Message:
    Addd console.mouse_mode (bit-field) property for visibility/control of sbbs internal ANSI-mouse-reporting mode flags (should not normally need to set this).
    console.getxy() now works with non-ANSI terminals and returns false if for some reason the request fails (e.g. ANSI cursor position report timeout).


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Sun Sep 13 12:37:10 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/ac3d31739f4048706ec50148
    Modified Files:
    src/sbbs3/js_console.cpp
    Log Message:
    Fixes to printfile and printtail methods

    Throw an exception if no filename is specified (rather than just abort the script by returning JS_FALSE).

    The return value is supposed to be a bool, not an int (JS_TRUE != JSVAL_TRUE).

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Fri Nov 6 20:02:11 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/43953c2d8ce1b2c984b60edd
    Modified Files:
    src/sbbs3/js_console.cpp
    Log Message:
    Address warning: unused variable ‘argv’

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tue Aug 6 18:11:10 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/049c18c41a02cf6a6934ecd5
    Modified Files:
    src/sbbs3/js_console.cpp
    Log Message:
    Fix potential null object pointer passed to JS_GetProperty in js_gotoxy()

    I'm not sure under what script conditions this could happen, but apparently Nelgin was able to produce this null pointer deref (and segfault) using DDMsgReader. This should fix issue #769

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Tue Aug 6 18:27:43 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/a2d6dc86b0b09664a1782cb6
    Modified Files:
    src/sbbs3/js_console.cpp
    Log Message:
    Better invalid argument reporting (null object) from js_gotoxy()

    The calling script will still terminate if it does this, but at least the caller will get a useful JS exception.

    Related to fix for issue #769

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Fri Dec 6 17:38:28 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/097e0162ab78524539fea92c
    Modified Files:
    src/sbbs3/js_console.cpp
    Log Message:
    Parse console.inkey() timeout parameter as an *unsigned* integer

    A negative timeout value doesn't make sense and this will extend the legal (positive) range of this parameter value.

    Hopefully this will help eliminate these errors I get often:
    dd_lightbar_menu.js line 4041: Error: can't convert inputTimeoutMS to an
    integer

    But if there's some way that this parameter value is even out of the range of an unsigned 32-bit value (4294967295) then this error could still happen. Unfortunately, the JS exception doesn't report the value that failed to convert.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Sat Jan 25 17:23:49 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/484706a8ba4fd641267db20a
    Modified Files:
    src/sbbs3/js_console.cpp
    Log Message:
    Add getkey_inactivity_warning property (alias: inactivity warning)

    Configured duration in seconds before warning about pending disconnection due to
    user/keyboard inactivity (or 0 if disabled).

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sat Jan 25 17:49:48 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/4e87ccf78f8d10121d96492b
    Modified Files:
    src/sbbs3/js_console.cpp
    Log Message:
    Resolve MSVC warning

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Sun Mar 2 20:44:35 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/db8708b2d9c285a40d79eeda
    Modified Files:
    src/sbbs3/js_console.cpp
    Log Message:
    Add console.cleartoeos() method

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net