From rswindell@VERT to CVS commit on Tue Apr 14 19:12:39 2020
src/sbbs3 scfgsave.c 1.91 1.92
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv1577
Modified Files:
scfgsave.c
Log Message:
smb_open_sub() will now create the msgbase if hasn't been created yet.
I noticed that more than one caller of smb_open_sub() would not call smb_create() if the sub had not been previously "created" and in some of the instances where they did call smb_create(), if create failed, the message base was errorneously left open. So just do the create here to elmiinate the chance of error (forgetting) and redundancy of logic.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
From rswindell@VERT to CVS commit on Tue Apr 14 19:27:39 2020
src/sbbs3 scfgsave.c 1.92 1.93
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv4188
Modified Files:
scfgsave.c
Log Message:
Use smb_fgetlength() instead of filelenth(fileno()).
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
From rswindell@VERT to CVS commit on Sun Aug 2 00:23:34 2020
src/sbbs3 scfgsave.c 1.95 1.96
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv14283
Modified Files:
scfgsave.c
Log Message:
Fix bug reported by WitNik (John):
The msgbase 'status' header created with smb_open_sub() had all its fields 0-filled.
This would cause all kinds of msgbase settings (e.g. max msgs, max age, etc.) to not propagate from their SCFG settings (for mail or sub-boards)
to the newly-created msg base(s).
But most importantly, it would cause the mail base to be created without the "EMail" attribute flag, causing the msgbase to be treated as a sub-board (public message area) and users could not then read their received mail.
The root-cause was that smb_open() will zero-out the current smb.status
value before trying to read it from the msgbase header, thus losing any
values that were populated in there before calling smb_open(). Rather than change the behavior of the ancient smb_open() function, just restore the correct default smb.status values after calling smb_open() and before
calling smb_create().
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Mon Nov 4 21:44:17 2024