src/sbbs3 str.cpp 1.86 1.87
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv23618

Modified Files:
str.cpp
Log Message:
Revert commit 1.70 from Sep-2015, use the documented behavior of the
"Use Location in User List" option. When set to false, the user's *note* (not IP address) is to be included in the user/logon lists.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/33a47954acf27412253bde79
Modified Files:
src/sbbs3/str.cpp
Log Message:
Use the passthru socket connection for node-spy

This enables node-spying via SSH or spying on a node that is using SSH.
Thanks Altere for the bug report.

---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/5c711045305acc7d52f03b63
Modified Files:
src/sbbs3/str.cpp
Log Message:
Improve the ANSI sequence parsing/stripping/pass-through in spy()

Strip all *but* the expected keyboard input sequences (arrow keys, pgup/dn, home, end, insert). Pass-through a bare ESC key (albeit with delay). ESC immediately followed by a key other than '[' should be very quickly passed through.
Increase the max ANSI sequence length from 31 to 256 chars.

---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/07c561f900bd466780ff1966
Modified Files:
src/sbbs3/str.cpp
Log Message:
CRLF after each protocol option when less than 80 column terminal

Beautification for 40 column terminals.

---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/300d0c127a1f2f44f684874b
Modified Files:
src/sbbs3/str.cpp
Log Message:
Close file description in error condition

Fix CID 516462

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/906b193a2109821b66062d43
Modified Files:
src/sbbs3/str.cpp
Log Message:
Fix case-sensitivity issue in charset element of path in last commit

fexistcase() only corrects the case of the filename, not the directories in
the path. So we'll just use the lowercase version of the charset string, always.

Also, return false upon failure of any call to replace_text(), not just the last one.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/7be352ac1ab689194d27bec1
Modified Files:
src/sbbs3/str.cpp
Log Message:
Support optional ctrl/<terminal-protocol>/text.ini file

If the sysop wants custom text.dat strings to be unique per terminal
connection protocol (e.g. telnet, rlogin, ssh, raw), this is how that
can be achieved (e.g. ctrl/rlogin/text.ini can be used to override text.dat strings only for RLogin connections).

To at least partially address issue #897

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/a81e64575c9f30c0a3af0fd5
Modified Files:
src/sbbs3/str.cpp
Log Message:
Rework part of the "good password" checking algorithm

Require that a good password contain a sequence of unique characters
(not repeating, incrementing, or decrementing in ASCII code value) of at least half the configured minimum password length. By default, the minimum password length is 4 chars, so this means a sequence of at least 2 unique characters
is required. If the minimum password length is increased by the sysop, so is the minimum required unique sequence length. The "PasswordInvalid" text.dat string is printed when passwords are rejected by this criteria.

Previously, the following would be rejected by this portion of the algo,
this logic has been replaced by the above:
- all chars the same (would print the "PasswordInvalid" text.dat string)
- first 4 chars are incrementing ("PasswordObvious" string printed)
- first 4 chars are decrementing ("PasswordObvious" string printed)

but now, a password that starts with "1234" or "abcd" is fine so long as it's longer than that and contains the minimum unique sequence length. This will prevent SBBS from rejecting high quality (e.g. randomly generated or crypto-hashed) passwords that just happen to begin with an incrementing sequence of 4 digits or alpha-characters.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/6e91b37768cb527efc9cd9d7
Modified Files:
src/sbbs3/str.cpp
Log Message:
Handle getuserdat() failure in sbbs_t::change_user()

Address Coverity CID 551209

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net