src/sbbs3 websrvr.c 1.716 1.717
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
websrvr.c
Log Message:
Fix transmission of files >= 2GB in size on systems that support large file offsets
(64-bit off_t), e.g. 64-bit Linux. Issue reported by plt via irc.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 websrvr.c 1.717 1.718
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv23357

Modified Files:
websrvr.c
Log Message:
Improve send-file performance on Windows (over Gb Ethernet LAN) from about 1 MBytes/second to 25+ MBytes/second by increasing the size of the ringbuffer (from 20 -> 256 KBytes) and the size of the file-read buffer in sock_sendfile().
Also log the through-put (in cps) when a file is sent.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 websrvr.c 1.718 1.719
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
websrvr.c
Log Message:
Address gcc warning: format '%d' expects argument of type 'int', but arg
has type 'long int'



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 websrvr.c 1.719 1.720
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv17800

Modified Files:
websrvr.c
Log Message:
The problem: the sysop (me) is not notified of critical errors (e.g. synchro.net zone file problems) in a timely manner.
Part of the solution: notify a configured user (e.g. user #1) via short-message/telegram and email/netmail logged-errors when messages of a configured severity (e.g. "Critical") are logged.
The second part of the solution (coming next) will be allowing timed events to log a message of a configurable severity logged when the event fails (returns a non-zero error level to sbbs).

I'm saving the error-notification-user-number and log-severity as part of the node.cnf file because:
- that's where the validation user number is already set
- I can conceive of a large system were certain node ranges (different instances of sbbs) might want different operators to be notified of logged-errors

This also means I eliminated all the legacy com port/modem stuff from the end of the node.cnf file. None of that is used in sbbs v3.

Also included in this commit are improvements around logging:
- reduce the severity of UDP recvfrom failures in services
- a more detailed log message when the mail server successfully delivers an email (via SMTP) - easier to answer the question: was that email you/they sent delivered successfully?


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/c9db48cec8efd56f8291443d
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Fix requests to the webserver using IPv6 address http://[1234:1234::] requests. The host portion contains ":" after split_port_part(), resulting in a 400 error.
Renaming is_legal_hostname() to is_legal_host(), since requests to webservers are to
"hosts" not "hostnames".

---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/d17a5ce0ba8d80a29f136c9e
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Merge branch 'leenooks/sbbs-master'

---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/37a23fea45bbdb3589e7d909
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Fix heap corruption that could occur when HSTS feature is enabled

At least on Windows, when realloc() is used to allocate a new buffer,
guess what's in that buffer initially? undefined values. So you can't
strcat() onto the end of that! Ouch. This was a fun one to track down.

---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/987c1129e127fe9a7b67d430
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Fix 32-bit GCC warning on rPi about printf format

format '%ld' expects argument of type 'long int', but argument 7 has type '__off64_t'

---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/c399ca73f145f7e8dc625ec6
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Some CGI programs know they're not running from a console because
QUERY_STRING is defined (even if blank).

Always define it.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/2c66387d8a91bc26d226430a
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Merge remote-tracking branch 'origin/master'

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/9a599dfabeaa11a2e042c4fc
Modified Files:
src/sbbs3/ftpsrvr.c mailsrvr.c main.cpp
Log Message:
Log and MQTT-public active client highwater values when seen/reached

We don't log highwate

https://gitlab.synchro.net/main/sbbs/-/commit/9a599dfabeaa11a2e042c4fc
Modified Files:
src/sbbs3/ftpsrvr.c mailsrvr.c main.cpp
Log Message:
Log and MQTT-public active client highwater values

https://gitlab.synchro.net/main/sbbs/-/commit/7fb6c7b4d8ec2150eefe55df
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Add missing argument to new error log message upone putuserdat() failure

Fixes a couple CIDs and a GCC warning

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/d98359abefd58e43bb0e3115
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Move max concurrent connections check into http_session_thread()

We can't send a 4xx error (ie: client did something wrong) in
plaintext on a TLS connection.

Untested beyond a basic compile check.

---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/913092779871fdf4f4fc3e56
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Since this is after client_on() is called now, use > not >=

---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/91125d1b721525a9c7720d0c
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Track and report the concurrent connections per client highwater mark

It's possible now for clients to easily exceed the configured max concurrent connections limit, even though they just get an error 429 page. Let's at least track and log when a new highwater mark is reached.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/ce7d83eeda506e5f366fe31d
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Add/use errprintf() to reduce severity of repeated error messages

Part of solution for issue #619 (for the web server)

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f2c891789734a9e783a1ac14
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Lower severity of repeated errors in js_ReportError()

This needed a custom solution (not errprintf) since the filename is passed-in is likely from dynamically allocated memory, so a pointer comparison isn't enough - and we don't get the function name.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/bbf9d5eac22ce15077a4599f
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Use errprintf() instead of lprintf() for one more log message

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/a4ac0be63a49cc98f4883bef
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Better NULL ptr checking in js_ErrorReporter, CID 516068

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/630b22ada39c50f871597b00
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Whitespace change only

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/91b5a37ca1155f71f28c6eda
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Check return value of JS_NewStringCopyZ (for NULL)

Kind of a shot in the dark here: Max (WESTLINE) is reporting HEAP CORRUPTION debug assertion in websrvr.dll. In the 2 instances reported, a long (336
char) JSON "query value" was logged by apparent spam-bot trying to create a
a new user account ("send-me-free-stuff" is one of the JSON properties).

JS_NewStringCopyZ() can return NULL in a low memory situation, though I don't know that explains possible heap corruption.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/196ad130ca1a7fbecc73807b
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Use errprintf for FastCGI related error log messages

I received 6853 duplicate FastCGI error emails today (sent in a 2 minute
time span). I wish I already had this in place. :-(

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/0afbc6a9ae33dc715e0125bc
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Fix NULL dereference when there are no directory vshortcuts defined

As reported by Accession in #synchronet at irc.synchro.net

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/3618930a6e23a5f3b5709a71
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Resolve GCC warning enumeration value ‘PARSED_VPATH_x’ not handled in switch

---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/0c6913fbd626457fb401aae8
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Another use of errprintf() to help de-dupe error logs/alerts

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/48ac38bbbed74e4e98830c36
Modified Files:
src/sbbs3/websrvr.c
Log Message:
More use of errprintf() to reduce duplicate error log messages

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/adf899cdeb60600fed167324
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Don't try to send 503 error for TLS connections that exceed maximum

since this doens't work and just generates/logs an error every time.

And for non-TLS connections, if the 503 send fails, just log it as a warning.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/8fe9b03cc155aee581fabce2
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Log output improvements

- include client protocol (HTTP or HTTPS) and IP address in more log messages
- include some more detail (e.g. send byte count) in "ERROR sending" message
- lower severity of "Executing FastCGI" log message from Info to Debug

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/38fde64dab9f2684f33ca3a6
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Fix max concurrent connections limit

broken in commit d98359abefd58e4

It'd send a 429 error, but keep accepting and processing client
requests, thus not really limiting the concurrent clients (from the same
IP) ever.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/e712db6e16c730fe515f9ea6
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Immediately reject non-TLS connections that exceed concurrent connections limit

Further revert commit d98359ab at least for non-HTTPS/TLS connections, so we
no longer needlessly create threads just to send a 429 error.

This along with the previous commit have restored my web severs to sustainable operation after the recent huge increase in volume of requests from a huge number of unique IP addresses of *.googleusercontent.com

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/14f0c3d11fda44d238ac4408
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Fix suspicion expressed by DigitalMan in IRC

Actually ensure the byte range starts with "bytes=".
If anyone defines something other than bytes in the future, this
will correctly give them an error instead of parsing everything after
the sixth byte as a byte range.

Also, fixes parsing of end-anchored ranges (ie: -100 and 100-)
and the special case of 0-0 (should send one byte)

---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/80e8cdc85ac76f4763d04b15
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Don't log an error if failed to sent error 429

Who cares if we fail to send the error to the client? No one cares, that's who cares. No one. No one cares. </trump>

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: src/sbbs3/websrvr.c
By: Rob Swindell (on Debian Linux) to Git commit to main/sbbs/master on Wed Jun 11 2025 05:17 pm

Who cares if we fail to send the error to the client? No one cares, that's who cares. No one. No one cares. </trump>

dont try to be funny. it doesn't work for you.
---
þ Synchronet þ ::: BBSES.info - free BBS services :::

https://gitlab.synchro.net/main/sbbs/-/commit/2c63bdb3fb7578360a3350f9
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Improve logging around SSJS-generated error page/sending

Reduce severity (to DEBUG) of "Using SSJS error page" message
Include protocol and IP address and error code in each message.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/2588c5cf72d9fe4a9e825f0e
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Increment local "served" count upon termination and include highwater mark

... in "Session thread terminated" log message

The "served" value logged wasn't monotonically incrementing since it was incremented before session threads were created/released, making the log message out of sync with reality.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/83c0999b76ef8ce0c77513a4
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Fix issue #942

Session is initialized to HTTP/0.9 (which doesn't send headers) and
the HEAD method (which doesn't send a body). This was caught in
writebuf(), which returned 0 due to the body not being sent, which
caused the error to be logged.

Set the values to HTTP/1.0 and GET so we can call send_error()
before we read a request line and actually send an error.

Additionally, add a LOG_INFO to writebuf() when it returns 0 due
to body being disabled to make this kind of thing easier to find
in the future.

Finally, don't attempt to send an error body if send_headers()
fails or if we should not send a body.

This would also allow us to send a 408 if we wanted to, but I've
never been convinced that's useful.

---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/76acaac000c1bba5e025f115
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Output the User-Agent header value as a info-level log message

Useful for tracking (some/most) bots

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/2d4af7be9e8a92ebbbc4242b
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Reduce contention on protected-int thread_count

We can capture the new value upon atomic-decrement, use it

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/4090d823bba9fa4630bd79c2
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Solve the active_clients exceeds configured max_clients issue

e.g. with [Web] max_clients configured for 200, the following could occur: sbbs: web 0522 HTTP [34.45.142.114] Session thread terminated (220 clients, 378 threads remain, 128627 served)

The issue was that the active_client count is incremented in the http_session_thread(), but was being checked in the main web server/listening thread.

So now we'll check in both threads, but allow more HTTPS/TLS client threads
(10 more) than the configured max, to allow for successfull sending of error 503 (up to a point), while HTTP (non-TLS) connections exceeding the configured max will be immediately dropped without creating a session thread.

We now no longer increment the client highwater mark for connections that exceed the maximum.

Also fix send_error() to not log the Connection: close\r\nContent-Length: 0\r\n portion of 503 errors.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/1f480068adc0ac59c5b4e663
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Apply max connections per IP limit to filter-exempted IPs

This exemption could (did) cause confusing "works for me" situations when testing max concurrent connections settings that may fail for others.

So, just because an IP address is listed in ctrl/ipfilter_exempt.cfg, no
longer means that clients at that IP are exempt from concurrent connection limits (from a single IP address).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/c0c3dbdf76d91f155a9371ca
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Revert "Apply max connections per IP limit to filter-exempted IPs"

This reverts commit 1f480068adc0ac59c5b4e6634dc827c52721a7da.

The other servers exempt ipfilter_exempt.cfg listed hosts still and it looks like I really need gitlab to be exempt from the concurrent connections limit for (all my) webhooks to work reliably since they run in parallel and I can't seem to configure that behavior in gitlab.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/a43ca30ea674ac77ca98d74e
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Pad "HTTP" to 5 chars for protocol field in log messages

... aligning display for easier reading with non-proportional fonts.

Includes the client's protocol and IP address in JS log messages/errors.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net