1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/putmsg.cpp

    From Rob Swindell@VERT to Git commit to sbbs/master on Mon Sep 7 19:03:45 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/225f441b1bff674fb9a575d9
    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    Eliminate unused variable.

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Mon Sep 7 20:08:02 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/749e288ff5e2b9865c269e50
    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    Merge branch 'master' of gitlab.synchro.net:sbbs/sbbs

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Thu Oct 8 20:12:37 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/9919c23e8e52f5b7bb9a79f4
    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    Don't pass-through ANSI Device Attributes (DA) requests

    putmsg(), used to display messages and display/menu files, will no longer pass-through the ANSI sequence ESC[c (found in some corrupted ANSI posts to fsxNet->FSX_BOT echo) to the client terminal since this will stimulate a (unwanted) response from the client.

    I do wonder if the outchar_esc value check should be == here instead of >=, but I'm not familiar with the string and SOS states. I wonder if any display files sent from the BBS would ever include those sequences.

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Hatton@VERT/THRCORN to Rob Swindell on Fri Oct 9 00:31:00 2020
    Rob Swindell wrote to Git commit to sbbs/master <=-

    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    Don't pass-through ANSI Device Attributes (DA) requests

    putmsg(), used to display messages and display/menu files, will no
    longer pass-through the ANSI sequence ESC[c (found in some corrupted
    ANSI posts to fsxNet->FSX_BOT echo) to the client terminal since this
    will stimulate a (unwanted) response from the client.

    Thank you!

    Hatton


    ... DalekDOS v(overflow): (I)Obey (V)ision impaired (E)xterminate
    --- MultiMail/Win v0.52
    þ Synchronet þ Three Corners and Beyond! http://3corners.us
  • From Digital Man@VERT to Hatton on Thu Oct 8 22:18:21 2020
    Re: Re: src/sbbs3/putmsg.cpp
    By: Hatton to Rob Swindell on Fri Oct 09 2020 12:31 am

    Rob Swindell wrote to Git commit to sbbs/master <=-

    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    Don't pass-through ANSI Device Attributes (DA) requests

    putmsg(), used to display messages and display/menu files, will no longer pass-through the ANSI sequence ESC[c (found in some corrupted ANSI posts to fsxNet->FSX_BOT echo) to the client terminal since this will stimulate a (unwanted) response from the client.

    Thank you!

    Sure. There are likely more sequences we might want to filter out of ANSI-encoded messages (or whitelist only the ones we *do* want to pass-through), but this'll work for now.

    digital man

    Synchronet "Real Fact" #95:
    Synchronet v3.15b was released in October of 2011 (5 years after v3.14a). Norco, CA WX: 62.8øF, 84.0% humidity, 3 mph ESE wind, 0.00 inches rain/24hrs

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Mon Nov 2 02:30:29 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/93dc3f128816d1ddb24b6cab
    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    Allow punctuation characters on either side of the markup tags

    So you can do stuff (*like this*).

    Also, we don't need to heavily scrutinize the closing tag when we come upon it because we already determined it was valid before we accepted the opening tag/character.

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Sun Nov 8 13:15:19 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/9090d40fc64d791bc7dd37a3
    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    Don't support back-to-back marks in markup parsing

    Addresses false-positive matches in URLs (e.g. https://minftn.net/) where the second slash was being interpreted as a the beginning of an italic markup.

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Sun Nov 8 15:57:40 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/515b0854e73a3f2ff5fb89a5
    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    Don't allow adjacent marked-up text.

    This allows us to ignore markup codes in a string like: "/sbbs/ctrl/*cnf*"

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Mon Feb 3 11:11:09 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/0178043e56c04ef741cbb1cb
    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    Correctly center lines of text that contain @-codes, after @center@

    @-codes weren't expanded before the text length calculation, so the centering logic (offset in the user's terminal screen) would usually be incorrect as pointed out by Nelgin in #synchronet when we were discussing the |C @-code modifier (which is to center an @-code value in a field, not the screen).

    This issue was a known limitation of the fix to issue #418 (commit 8987150bd) but now that we have the expand_atcodes() function (hooray!), this is an
    easily solvable problem.

    Note: we're now calling center() withOUT the 'msg' parameter set to true,
    which means the @center@ code goes back to the previous (to issue #418 fix) behavior of just using bputs() for the centered text (we don't need the recursive call to pustmsg() to support @-codes any longer). This was the only reason that center() grew the optional 'msg' parameter so we likely can remove that option/feature at some date.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Mon Mar 24 01:14:25 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/1886c63776b7cfa454dfb9ca
    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    Clean-up the hex and decimal value parsing of "extra attribute codes"

    Eliminate the unnecessary calls to snprintf() and atoi()/ahtoul() since these are simple fixed-length parses. No change in behavior, just a minor optimization.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net