1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/zmodem.c

    From Rob Swindell@VERT to Git commit to main/sbbs/master on Fri Nov 27 01:48:05 2020
    https://gitlab.synchro.net/main/sbbs/-/commit/df15131bdb18831c6646ddff
    Modified Files:
    src/sbbs3/zmodem.c
    Log Message:
    zmodem_recv_files() now returns upon first failed file.

    Previously, a ZRINIT frame would be sent even after a failed file download, and this could be misinterpreted by the sender as a successful file receipt
    acknowledgement. 'lrz' just completely aborts the receive "batch" under the same conditions, so we'll just do the same to prevent the sender (e.g. BBS) from mistakenly counting this as a successful transfer (download).

    A lot of log message updates: additions, removals, and use of the __FUNCTION__ macro.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Fri Nov 27 02:04:08 2020
    https://gitlab.synchro.net/main/sbbs/-/commit/6ffdef9ff1449de30ea478ce
    Modified Files:
    src/sbbs3/zmodem.c
    Log Message:
    Fix build error introduce in previous commit.

    __FUNCTION__ cannot be used a string literal in GCC.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Fri Nov 27 14:07:55 2020
    https://gitlab.synchro.net/main/sbbs/-/commit/8a4698c5a581d8a42c462878
    Modified Files:
    src/sbbs3/zmodem.c
    Log Message:
    Include file/progress byte-offset at the beginning of log messages

    Makes easier trace/debugging of issues (e.g. matching up with sending side logs).
    No functional change.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Fri Nov 27 22:02:22 2020
    https://gitlab.synchro.net/main/sbbs/-/commit/b8797f3e9335f0bb89883cdb
    Modified Files:
    src/sbbs3/zmodem.c
    Log Message:
    More log output messages/detail. No functional change.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sat Nov 28 00:39:25 2020
    https://gitlab.synchro.net/main/sbbs/-/commit/d1259998004d6e3f47be6066
    Modified Files:
    src/sbbs3/zmodem.c
    Log Message:
    zmodem_recv_file_data() will purge receive buffer before sending ZRPOS, but...

    only when the errored data subpacket was a ZCRCW (waiting for ZACK).
    To resolve a non-streaming failure to recover after CRC error issue.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sat Nov 28 02:43:29 2020
    https://gitlab.synchro.net/main/sbbs/-/commit/421db04420bcc48b5ca3f38f
    Modified Files:
    src/sbbs3/zmodem.c
    Log Message:
    Insure receive buffer is purged before sending ZRPOS.

    Also, zmodem_send_raw() was saving the "last sent" char, even if it wasn't successfully sent.

    Eliminated the "errors" mode of zmodem_recv_header_raw() since was no longer used.
    Eliminated zmodem_recv_header_and_check() since it's no longer used.

    Some debug-log fix-ups (e.g. with progress/offset).

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sat Nov 28 05:07:12 2020
    https://gitlab.synchro.net/main/sbbs/-/commit/074edbc12b9163e8a0e8e10b
    Modified Files:
    src/sbbs3/zmodem.c
    Log Message:
    Better HEX frame corruption detection.

    More logging details (e.g. subpacket byte progress).
    Identify XON and XOFF by name (e.g. when purging receive buffer).
    Some variable naming and comment improvements.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Thu Jan 2 17:40:12 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/57e0d22816044e34efcf7e0d
    Modified Files:
    src/sbbs3/zmodem.c
    Log Message:
    Resolve newly added MSVC warning

    warning C4244: 'return': conversion from 'uint64_t' to 'unsigned int',
    possible loss of data

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Fri Jan 3 11:46:22 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/d2cd0a651384b4c6f9ccfd3a
    Modified Files:
    src/sbbs3/zmodem.c
    Log Message:
    Ok, so the real issue Coverity has is the tainting of nX.

    Have zmodem_recv_nibble() explicitly range-check all values, and
    handle negative values. If this remains an issue, it can be
    untainted with range checks on each nibble, but let's not go there
    to start with.

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Sat Jan 4 00:52:27 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/35f2ec2f73a22d3b7702787a
    Modified Files:
    src/sbbs3/zmodem.c
    Log Message:
    So, Coverity knows that won't happen, so that just creates a new issue

    Try untainting it in recv_hex... if that doesn't work, I'll just
    have to ignore it I guess.

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Sat Jan 4 01:51:54 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/8be9b414e85a30b6da2cdb06
    Modified Files:
    src/sbbs3/zmodem.c
    Log Message:
    Yep, Coverity knows those won't do anything.

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Sat Jan 4 13:36:34 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/f5db57c486e22411d71e861c
    Modified Files:
    src/sbbs3/zmodem.c
    Log Message:
    Suppress Coverity overflow issue.

    This can't actually happen.

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Sat Jan 4 16:19:54 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/430f50363dcd4db76e06906d
    Modified Files:
    src/sbbs3/zmodem.c
    Log Message:
    So, Coverity knows that won't happen, so that just creates a new issue

    Try untainting it in recv_hex... if that doesn't work, I'll just
    have to ignore it I guess.

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Sat Jan 4 16:19:54 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/6ab3066724eee2426b2c2480
    Modified Files:
    src/sbbs3/zmodem.c
    Log Message:
    Yep, Coverity knows those won't do anything.

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Sat Jan 4 16:19:54 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/02a684faf4f89b31d450d02c
    Modified Files:
    src/sbbs3/zmodem.c
    Log Message:
    Suppress Coverity overflow issue.

    This can't actually happen.

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net